[NFC][Bitcode] Remove FUNCTION_INST_UNOP abbrevs #146717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed in llvm#146497. Seems to have a positive impact on bitcode file size in CTMark LTO builds, and makes space for more abbrevs without bumping the CodeLen for function blocks. Alternatively, we could just bump the CodeLen to 5 bits.
|
Looks like we're moving ahead with CodeLen increasing to 5 bits. @nikic should we abandon this? It looks like it does slightly improve sizes overall, but could have a negative affect on some workloads... seems safer to drop it now that we don't need to keep CodeLen down. I'm happy either way. |
|
Yeah, I think we can drop this for now. Without the CodeLen change, the benefit of dropping it is minimal (it will only save emitting two abbrev records, right?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #146497.
Seems to have a positive impact on bitcode file size in CTMark LTO builds, and makes space for more abbrevs without bumping the CodeLen for function blocks.
Alternatively, we could just bump the CodeLen to 5 bits.